Remove EIP-7742#8083
Merged
siladu merged 1 commit intobesu-eth:mainfrom Jan 7, 2025
Merged
Conversation
Revert "Rename targetBlobCount to targetBlobsPerBlock (besu-eth#7981)" This reverts commit 1671306. Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Revert "EIP-7742: Add target_blob_count to block header (besu-eth#7808)" This reverts commit f855d5b. Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
macfarla
approved these changes
Jan 7, 2025
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
This EIP was removed and equivalent functionality replaced by EIP-7840. --- Revert "Rename targetBlobCount to targetBlobsPerBlock (besu-eth#7981)" This reverts commit 1671306. Revert "EIP-7742: Add target_blob_count to block header (besu-eth#7808)" This reverts commit f855d5b. Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This EIP was removed and equivalent functionality replaced by EIP-7840.
This PR boils down to removing targetBlobsPerBlock from the Block header since 7742 engine API changes were never merged.
The EIP-7742 gas calculation commit 472357f was already reused/adapted as part of the EIP-7840 implementation e830db7