[FLAKE] disable CliqueProposeRpcAcceptanceTests x 2#8035
Merged
macfarla merged 2 commits intobesu-eth:mainfrom Dec 17, 2024
Merged
[FLAKE] disable CliqueProposeRpcAcceptanceTests x 2#8035macfarla merged 2 commits intobesu-eth:mainfrom
macfarla merged 2 commits intobesu-eth:mainfrom
Conversation
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Matilda-Clerke
approved these changes
Dec 16, 2024
Contributor
Matilda-Clerke
left a comment
Matilda-Clerke
left a comment
There was a problem hiding this comment.
LGTM. Do we have issues raised to try to fix the flakiness?
Contributor
Author
there is #7973 which is linked to this PR but I won't close it. if you look for the |
daniellehrner
pushed a commit
to daniellehrner/besu
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
PR description
Fixed Issue(s)
Refs #7973
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTestsSigned-off-by: Sally MacFarlane sally.macfarlane@consensys.net