Chore!: Removed Deprecated --host-whitelist option#8012
Merged
macfarla merged 8 commits intobesu-eth:mainfrom Dec 11, 2024
Merged
Chore!: Removed Deprecated --host-whitelist option#8012macfarla merged 8 commits intobesu-eth:mainfrom
--host-whitelist option#8012macfarla merged 8 commits intobesu-eth:mainfrom
Conversation
Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com>
Contributor
|
@pr9t also need to update this file besu/src/test/resources/everything_config.toml - there's a unit test failing |
macfarla
reviewed
Dec 10, 2024
Contributor
macfarla
left a comment
macfarla
left a comment
There was a problem hiding this comment.
also needs a changelog entry - this will be a breaking change in the upcoming release
…ange in CHANGELOG.md file Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com>
macfarla
reviewed
Dec 11, 2024
Contributor
ok I realise on re-reading that this is confusing. The "Unreleased" release gets turned into the next release at some point, and this PR will be a "breaking change" in that release rather than an "upcoming breaking change" |
Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com>
Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com>
pr9t
changed the title
--host-whitelist option
pr9t
changed the title
--host-whitelist option--host-whitelist option
macfarla
approved these changes
Dec 11, 2024
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
…eprecatedHostWhitelistRemove
daniellehrner
pushed a commit
to daniellehrner/besu
that referenced
this pull request
Dec 18, 2024
* Chore:Removed Deprecated --host-whitelist option * chore: Update everything_config.toml and Updated upcoming Breaking Change in CHANGELOG.md file Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com> --------- Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
* Chore:Removed Deprecated --host-whitelist option * chore: Update everything_config.toml and Updated upcoming Breaking Change in CHANGELOG.md file Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com> --------- Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
BREAKING CHANGE:
--host-whitelistoption has been removed.Fixed Issue(s)
fixes #7761
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests