Skip to content

Update EOFCREATE memory code#7979

Merged
siladu merged 5 commits intobesu-eth:mainfrom
shemnon:eof/eofcreate-memsize
Dec 8, 2024
Merged

Update EOFCREATE memory code#7979
siladu merged 5 commits intobesu-eth:mainfrom
shemnon:eof/eofcreate-memsize

Conversation

@shemnon
Copy link
Copy Markdown
Contributor

@shemnon shemnon commented Dec 3, 2024

PR description

Switch to longs so EOFCREATE can handle gigagas sized transactions.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Switch to longs so EOFCREATE can handle gigagas sized transactions.

Signed-off-by: Danno Ferrin <danno@numisight.com>
@shemnon
Copy link
Copy Markdown
Contributor Author

shemnon commented Dec 3, 2024

tests are here - ethereum/execution-spec-tests#989

Copy link
Copy Markdown
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Switch to longs so EOFCREATE can handle gigagas sized transactions.

Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
@siladu siladu merged commit 1855836 into besu-eth:main Dec 8, 2024
daniellehrner pushed a commit to daniellehrner/besu that referenced this pull request Dec 18, 2024
* Update EOFCREATE memory code

Switch to longs so EOFCREATE can handle gigagas sized transactions.

Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
pullurib pushed a commit to pullurib/besu that referenced this pull request Feb 6, 2025
* Update EOFCREATE memory code

Switch to longs so EOFCREATE can handle gigagas sized transactions.

Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants