[CONTRIBUTING] add trivial change clause#7972
Merged
macfarla merged 3 commits intobesu-eth:mainfrom Dec 6, 2024
Merged
Conversation
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
siladu
reviewed
Dec 3, 2024
| * To ask questions or chat with us, join our [Discord](https://discord.com/invite/hyperledger) | ||
| * To edit pages in our wiki, you'll need a [Linux Foundation (LF) account]. | ||
|
|
||
| Please keep in mind that we do not accept non-code contributions like fixing comments, typos or some other trivial fixes. Although we appreciate the extra help, managing lots of these small contributions is unfeasible, and puts extra pressure in our continuous delivery systems (running all tests, etc). Feel free to open an issue pointing any of those errors, and we will batch them into a single change. |
Contributor
There was a problem hiding this comment.
If you add a header section, you should be able to link directly to it.
siladu
approved these changes
Dec 3, 2024
Contributor
siladu
left a comment
There was a problem hiding this comment.
LGTM, linkable header section would be a minor improvement
lu-pinto
approved these changes
Dec 3, 2024
Contributor
lu-pinto
left a comment
There was a problem hiding this comment.
Even though there's some helpful comment fixes it can be a bit of a gray area what to and what not to allow, so I think not allowing them altogether is what makes most sense from the POV of time/resources wasted with little benefit.
The approach to just create issues for typos is a good one IMO.
daniellehrner
approved these changes
Dec 3, 2024
fab-10
approved these changes
Dec 3, 2024
jframe
approved these changes
Dec 4, 2024
jflo
approved these changes
Dec 4, 2024
matthew1001
approved these changes
Dec 5, 2024
This was referenced Dec 10, 2024
daniellehrner
pushed a commit
to daniellehrner/besu
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Adds a clause covering trivial changes. We've seen an increase in this type of PR lately (typos, punctuation, and other trivial changes). These add load to CI and also to reviewers. Until now we did not have a policy on these types of PRs.
These words came from Teku
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests