Add RPC WS options to specify password file for keystore and truststore#7970
Add RPC WS options to specify password file for keystore and truststore#7970fab-10 merged 4 commits intobesu-eth:mainfrom
Conversation
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
fab-10
left a comment
There was a problem hiding this comment.
Looks good, just update the CHANGELOG
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com>
| rpc-ws-ssl-client-auth-enabled=false | ||
| rpc-ws-ssl-truststore-file="none.pfx" | ||
| rpc-ws-ssl-truststore-password="none.passwd" | ||
| rpc-ws-ssl-truststore-password-file="none.txt" |
There was a problem hiding this comment.
does it make sense to specify both password and password-file or should we only allow one or the other?
There was a problem hiding this comment.
that is handled by @CommandLine.ArgGroup(exclusive = true, multiplicity = "1")
There was a problem hiding this comment.
Yeah, that's the intent using ArgGroup to make them exclusive but it doesn't seem to work when I tested. Right now , password takes precedence over password file if both are specified. I'll track this in a new issue
|
@pullurib please check if this failing test is related to your change |
|
They pass when I sync my local branch and run the tests locally. I do see an error log though Looks like that is expected by the tests |
PR Description
Fixed Issue(s)
#7931