Skip to content

Shutdown MetricsSystem when stopping MetricsService#7958

Merged
fab-10 merged 1 commit intobesu-eth:mainfrom
fab-10:shutdown-metrics-system-on-stop
Nov 28, 2024
Merged

Shutdown MetricsSystem when stopping MetricsService#7958
fab-10 merged 1 commit intobesu-eth:mainfrom
fab-10:shutdown-metrics-system-on-stop

Conversation

@fab-10
Copy link
Copy Markdown
Contributor

@fab-10 fab-10 commented Nov 28, 2024

PR description

Shutdown MetricsSystem when stopping MetricsService, so any registered collector is cleaned, that is most useful during acceptance tests.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 enabled auto-merge (squash) November 28, 2024 11:47
@fab-10 fab-10 merged commit 0cbcd91 into besu-eth:main Nov 28, 2024
@fab-10 fab-10 deleted the shutdown-metrics-system-on-stop branch November 29, 2024 10:02
ahamlat pushed a commit to ahamlat/besu that referenced this pull request Dec 2, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
@lxcmyf
Copy link
Copy Markdown

lxcmyf commented Mar 19, 2025

besu/metrics/core/src/main/java/org/hyperledger/besu/metrics/prometheus
/MetricsPushGatewayService.java
I noticed that there is an implementation based on the Prometheus push data pattern here, and I would like to know if this push is long-term or temporary? Because Prometheus has explicitly stated that pushgateway is only suitable for short-term temporary data push usage.
@fab-10

@fab-10
Copy link
Copy Markdown
Contributor Author

fab-10 commented Mar 19, 2025

@lxcmyf since the introduction of the push gateway predates me, I searched why it was introduced and found the original requirement here 319ee20, so it should only be used if the normal pull mode is not feasible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants