fix TransactionLocation in DefaultBlockchain unsafeImportBlock() #7956
Merged
pinges merged 4 commits intobesu-eth:mainfrom Nov 29, 2024
Merged
fix TransactionLocation in DefaultBlockchain unsafeImportBlock() #7956pinges merged 4 commits intobesu-eth:mainfrom
pinges merged 4 commits intobesu-eth:mainfrom
Conversation
…make some readability improvements Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
jframe
reviewed
Nov 28, 2024
| for (int i = 0; i < nbTrx; i++) { | ||
| final Hash transactionHash = block.getBody().getTransactions().get(i).getHash(); | ||
| updater.putTransactionLocation(transactionHash, new TransactionLocation(transactionHash, i)); | ||
| for (int index = 0; index < nbTrx; index++) { |
Contributor
There was a problem hiding this comment.
The indexTransactionForBlock could be used here to remove some duplicated code
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
ahamlat
pushed a commit
to ahamlat/besu
that referenced
this pull request
Dec 2, 2024
…u-eth#7956) * fix TransactionLocation in DefaultBlockchain unsafeImportBlock() and make some readability improvements Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Fix the TransactionLocation in unsafeImportBlock()
fixes #7955