TransactionSimulator can be a singleton#7925
Merged
daniellehrner merged 2 commits intobesu-eth:mainfrom Nov 29, 2024
Merged
Conversation
fab-10
force-pushed
the
create-transaction-simulator-once
branch
5 times, most recently
from
84697c1 to
580e145
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
create-transaction-simulator-once
branch
from
580e145 to
07ff952
Compare
ahamlat
pushed a commit
to ahamlat/besu
that referenced
this pull request
Dec 2, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: daniellehrner <daniel.lehrner@consensys.net> Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Refactor only PR, to instantiate the
TransactionSimulatoronly one at startup and passing it around where needed, instead of recreating it in many places, this will make future PRs to support simulating txs on pending block easier.Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests