Skip to content

Privacy RPC methods - @Deprecate#7903

Merged
macfarla merged 2 commits intobesu-eth:mainfrom
macfarla:deprecate-privacy-rpc-methods
Nov 25, 2024
Merged

Privacy RPC methods - @Deprecate#7903
macfarla merged 2 commits intobesu-eth:mainfrom
macfarla:deprecate-privacy-rpc-methods

Conversation

@macfarla
Copy link
Copy Markdown
Contributor

PR description

Added @deprecated annotations to all privacy-related RPC methods

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Copy link
Copy Markdown
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla enabled auto-merge (squash) November 25, 2024 06:36
@macfarla macfarla merged commit 788b29f into besu-eth:main Nov 25, 2024
@macfarla macfarla deleted the deprecate-privacy-rpc-methods branch December 5, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants