Skip to content

[TEST] extra testing for host and port default values #7741

Merged
macfarla merged 3 commits intobesu-eth:mainfrom
macfarla:more-test-defaults
Oct 14, 2024
Merged

[TEST] extra testing for host and port default values #7741
macfarla merged 3 commits intobesu-eth:mainfrom
macfarla:more-test-defaults

Conversation

@macfarla
Copy link
Copy Markdown
Contributor

@macfarla macfarla commented Oct 8, 2024

PR description

follow on from #7725 to add extra testing for host and port values

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla enabled auto-merge (squash) October 14, 2024 00:56
@macfarla macfarla merged commit fd50a3e into besu-eth:main Oct 14, 2024
@macfarla macfarla deleted the more-test-defaults branch October 20, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants