Skip to content

Chore:Resolved EnginerGetClientVersionV1 fails for local build#7687

Merged
macfarla merged 4 commits intobesu-eth:mainfrom
pr9t:chore/EngineGetClientVersionV1Fails
Sep 29, 2024
Merged

Chore:Resolved EnginerGetClientVersionV1 fails for local build#7687
macfarla merged 4 commits intobesu-eth:mainfrom
pr9t:chore/EngineGetClientVersionV1Fails

Conversation

@pr9t
Copy link
Copy Markdown
Contributor

@pr9t pr9t commented Sep 27, 2024

PR description

Resolved the engine_getClientVersionV1 fails with an NPE when running Besu locally using Intellij.

Fixed Issue(s)

fixes #7585

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com>
@macfarla macfarla enabled auto-merge (squash) September 29, 2024 21:19
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla merged commit f541710 into besu-eth:main Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EngineGetClientVersionV1 fails for local build of Besu

2 participants