Skip to content

Change evmtool eof-test handling of empty code #7675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macfarla merged 4 commits into from
Oct 4, 2024
Merged

Change evmtool eof-test handling of empty code #7675

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1333a6
Change evmtool eof-test handling of empty code
shemnon Sep 24, 2024
93f9b4e
Merge branch 'main' into eof/empty_test
macfarla Sep 30, 2024
c183442
Merge branch 'main' into eof/empty_test
shemnon Sep 30, 2024
ba7f34b
Merge branch 'main' into eof/empty_test
shemnon Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ethereum/evmtool/src/main/java/org/hyperledger/besu/evmtool/EOFTestSubCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ public TestResult considerCode(final String hexCode) {
return failed(re.getMessage());
}
if (codeBytes.isEmpty()) {
return passed();
return failed("invalid_magic code is zero-length");
}

var layout = EOFLayout.parseEOF(codeBytes);
Expand Down