Skip to content

7311: Add feature toggle for enabling use of the peertask system where available#7633

Merged
jframe merged 21 commits intobesu-eth:mainfrom
Matilda-Clerke:7311-add-cli-feature-toggle-for-peertask-system
Sep 24, 2024
Merged

7311: Add feature toggle for enabling use of the peertask system where available#7633
jframe merged 21 commits intobesu-eth:mainfrom
Matilda-Clerke:7311-add-cli-feature-toggle-for-peertask-system

Conversation

@Matilda-Clerke
Copy link
Copy Markdown
Contributor

PR description

Adds a feature toggle to enable use of the peer task system. To be utilised in future PRs implementing usage of the peer task system

…e available

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…tantiation

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…en initializing PeerTaskFeatureToggle multiple times

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…peertask-system' into 7311-add-cli-feature-toggle-for-peertask-system
Copy link
Copy Markdown
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toggle code looks good.

It would be good to get a rough idea about how it will be used in the full shebang #7602

The POC touches a lot of existing code so could get messy (it's mostly wiring no doubt!)

@Matilda-Clerke
Copy link
Copy Markdown
Contributor Author

@siladu It's a little messy, but as you said it's just wiring. You can see how it'll be used in #7638 (still some bugs to work out before that's ready for review)

@jframe jframe merged commit 4f07e76 into besu-eth:main Sep 24, 2024
Wolmin pushed a commit to lukso-network/network-besu that referenced this pull request Sep 27, 2024
…e available (besu-eth#7633)

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Wolmin <lamonos123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants