Create and publish Besu BOM (Bill of Materials)#7615
Merged
fab-10 merged 1 commit intobesu-eth:mainfrom Oct 18, 2024
Merged
Conversation
96d094a to
66c0b1c
Compare
Contributor
|
This looks clean, but could you provide a description and motivation for the change? |
Contributor
Author
|
Thanks @garyschulte, I just forgot to add it, done now. |
siladu
reviewed
Sep 24, 2024
Contributor
siladu
left a comment
There was a problem hiding this comment.
Looks good, just couple of questions...
Does this PR have any impact on the license report?
https://github.com/hyperledger/besu/blob/0d6395515890280c29ee2402c03b1ee81bde3bab/build.gradle#L113-L114
Contributor
Author
I have checked and the licenses are checked and the report is produced as before. |
cfcb1ea to
b07c7e1
Compare
siladu
approved these changes
Sep 24, 2024
Contributor
siladu
left a comment
There was a problem hiding this comment.
LGTM thanks for answering my questions
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Introducing Besu BOM (bill of materials) to improve the way we manage shared dependencies between Besu and plugins.
It is based on Gradle Java Platform plugin and it is also used internally, replacing the Spring Dependency Manager, it is then published as BOM artifacts so it can be used as reference in plugins for all the dependencies that are in common with Besu, this way it is easier to spot dependencies incompatibilities when developing plugins.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests