refactor SimpleWorld to use Optional for storing accounts and extra null checks#7532
Merged
matkt merged 1 commit intobesu-eth:mainfrom Sep 2, 2024
Merged
Conversation
lu-pinto
force-pushed
the
simple-world-commit-add-null-check
branch
2 times, most recently
from
c95a75b to
483d772
Compare
shemnon
reviewed
Aug 28, 2024
garyschulte
reviewed
Aug 28, 2024
garyschulte
reviewed
Aug 28, 2024
garyschulte
reviewed
Aug 28, 2024
lu-pinto
force-pushed
the
simple-world-commit-add-null-check
branch
from
483d772 to
1e26c71
Compare
lu-pinto
commented
Aug 29, 2024
garyschulte
approved these changes
Aug 29, 2024
lu-pinto
force-pushed
the
simple-world-commit-add-null-check
branch
from
d16ccc8 to
ae29100
Compare
lu-pinto
force-pushed
the
simple-world-commit-add-null-check
branch
from
ae29100 to
631ee4b
Compare
lu-pinto
force-pushed
the
simple-world-commit-add-null-check
branch
3 times, most recently
from
de2fced to
15e126d
Compare
auto-merge was automatically disabled
September 2, 2024 09:43
Head branch was pushed to by a user without write access
lu-pinto
force-pushed
the
simple-world-commit-add-null-check
branch
from
15e126d to
eb186c4
Compare
…ull checks Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
lu-pinto
force-pushed
the
simple-world-commit-add-null-check
branch
from
eb186c4 to
1a39d1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Fix several NPEs in
SimpleWorldand I also decided to useOptionalfor accounts since the return fromget/getAccountwas ambiguous between an account that has been deleted or has never existed. Now there's a clear distinction between deleted (Optional.empty()) or has never existed (null). AlsogetTouchedAccountsreturned null values when there were deleted accounts within which can be dangerous to the caller.Note:
SimpleWorldseems to only be used by the test framework, so this is not critical.Fixed Issue(s)
fixes #7524
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests