Add network support for ephemery testnet by gconnect · Pull Request #7471 · besu-eth/besu

gconnect · 2024-08-16T02:36:21Z

PR description

Fixed Issue(s)

Add Ephemery genesis file to the resources
Add Ephemery network to NetworkName
Add test for Ephemery to BesuCommandTest
Add Ephemery to NetworkDeprecationTest file
Add Ephemery genesis function to automatically generate a new genesis file in line with the spec requirements for Ephermery Testnet
Add test for the genesis generation function

This PR is in response to this issue 7404

@non-fungible-nelson please review when you have some time.

Thanks for sending a pull request! Have you done the following?

Checked out our contribution guidelines?
Considered documentation and added the doc-change-required label to this PR if updates are required.
Considered the changelog and included an update if required.
For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

unit tests: ./gradlew build
acceptance tests: ./gradlew acceptanceTest
integration tests: ./gradlew integrationTest
reference tests: ./gradlew ethereum:referenceTests:referenceTests

macfarla · 2024-08-21T01:30:11Z

@gconnect is this still WIP as the title suggests, or ready for review?

gconnect · 2024-08-21T01:40:10Z

@gconnect is this still WIP as the title suggests, or ready for review?

Yes @macfarla it is. Currently working on the requested changed. I have made most of the changes what is left is the test. Should be done with it later today and push update then remove the WIP.

Also a quick one, I created the standalone class under the utils directory am not sure if it's okay there.

gconnect · 2024-08-23T05:32:33Z

@gconnect is this still WIP as the title suggests, or ready for review?

@macfarla is ready for review. Thank you.

* exclude permissioning test from default ATs run on PRs Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>

… trace (besu-eth#7336) * eliminate non-constant string concatenation from debug and trace Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * adjustments Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>

--------- Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>

…su-eth#7296) Optimistic transaction parallelization execution during block processing to improve the performances. This feature can enabled with a flag --Xbonsai-parallel-tx-processing-enabled=true Signed-off-by: Karim Taam <karim.t2am@gmail.com> Co-authored-by: Ameziane H <ameziane.hamlat@consensys.net> Co-authored-by: garyschulte <garyschulte@gmail.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

* 7732: Remove datagas related stuff in favour of blobgas Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> --------- Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>

Fix NPE for legacy ForkId with no forks Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>

…resh, not just the first one (besu-eth#7314) * Add new config option to use bootnodes during any peer table refresh, not just the first one Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Update everything-config list Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Revert debug setting Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Update ethereum/p2p/src/main/java/org/hyperledger/besu/ethereum/p2p/discovery/internal/PeerDiscoveryController.java Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: Matt Whitehead <matthew1001@hotmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Matt Whitehead <matthew1001@hotmail.com> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

This avoids executing TrieLogPruner.preload Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>

Add unit tests to the EXTCODE* series operations. Also, put all EVM operations tests in the proper package. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

Signed-off-by: gconnect <agatevureglory@gmail.com>

…ction pool (besu-eth#7359) * Introduce score for pending transactions Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Introduce score for pending transactions Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Update package javadoc Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>

…esu-eth#7377) * Update GeneralStateTestCaseEipSpec for use in linea-arithmetization Signed-off-by: Gaurav Ahuja <gauravahuja9@gmail.com> * formatting Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Gaurav Ahuja <gauravahuja9@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

…act (besu-eth#7380) Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

There is still a startup error when bonsai-limit-trie-logs-enabled is explicitly set to true --------- Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>

* Do not maintain connections to bootnodes Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Update changelog entry Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

Also reduce pruning window from 30_000 to 5_000 --------- Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

…exist (besu-eth#7305) Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>

…Info is null (besu-eth#7508) Signed-off-by: kesrishubham2510 <shubhamkeshari90@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

Signed-off-by: Neo <neowang725@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

…7517) * fleet-mode safe behavior for fcU in SynchronizationService Signed-off-by: garyschulte <garyschulte@gmail.com> * spotless Signed-off-by: garyschulte <garyschulte@gmail.com> --------- Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

* EVMTool should respect --genesis option Update the code so that the genesis file option will be respected when set. Also, default --fork options should set a rational base fee. Signed-off-by: Danno Ferrin <danno@numisight.com> --------- Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

The fuzzAll task depended on targets that didn't exist. Signed-off-by: Danno Ferrin <danno@numisight.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

* Release checklist update More details on homebrew and docs releases in release checklist issue template Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Chaminda Divitotawela <cdivitotawela@users.noreply.github.com> * Remove release creation for besu-docs from checklist It has been agreed there is no value creating releases in the hyperledger/besu-docs repo. Remove the related instruction from checklist Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> --------- Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> Signed-off-by: Chaminda Divitotawela <cdivitotawela@users.noreply.github.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>

Signed-off-by: gconnect <agatevureglory@gmail.com>

Signed-off-by: Glory Agatevure <agatevureglory@gmail.com>

gconnect · 2024-08-26T13:41:28Z

@macfarla I have made the requested changes.

… test Signed-off-by: gconnect <agatevureglory@gmail.com>

Signed-off-by: gconnect <agatevureglory@gmail.com>

gconnect · 2024-08-28T22:57:29Z

@macfarla I have made the requested changes and added the update changelog.md file

macfarla

it's coming together! a few more comments

macfarla · 2024-08-29T04:53:44Z

+      ephemeryGenesisFile =
+          new EphemeryGenesisFile(readGenesisConfigFile(), readGenesisConfigOptions());
+      ephemeryGenesisFile.updateGenesis();
+    }


I actually think lines 1096 - 1100 should be part of readGenesisConfigFile() so that calling readGenesisConfigFile will always give you the effective genesis file, and then maybe you don't need to modify the EPHEMERY networkName object itself.

Moving the code to this readGenesisConfigFile() resulted in a recursive error. I placed the code where it is now because I want the check to happen on client start

Signed-off-by: gconnect <agatevureglory@gmail.com>

gconnect · 2024-09-03T04:56:12Z

@macfarla I am closing the PR. I opened a new PR here

gconnect · 2024-09-03T04:56:42Z

@macfarla I am closing the PR. I opened a new PR #7563

gconnect force-pushed the add-network-support-for-ephemery-testnet branch from 3f6b682 to f58f4e0 Compare August 17, 2024 21:59

macfarla reviewed Aug 19, 2024

View reviewed changes

gconnect changed the title ~~[WIP] Add network support for ephemery testnet~~ Add network support for ephemery testnet Aug 23, 2024

macfarla reviewed Aug 26, 2024

View reviewed changes

macfarla and others added 23 commits August 26, 2024 13:47

[minor] Remove redundant info from plugin summary (besu-eth#7339)

62cee8a

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>

Update release checklist (besu-eth#7329)

ba98608

Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>

Add metrics for trie log pruner (besu-eth#7352)

e85dd37

--------- Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>

Fix NPE for legacy ForkId with no forks (besu-eth#7349)

3d7ad16

Fix NPE for legacy ForkId with no forks Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>

Disable limit trie logs for trie log subcommand (besu-eth#7366)

4b31e6e

This avoids executing TrieLogPruner.preload Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>

Add EXTCODE* unit Tests (besu-eth#7374)

d5f0364

Add unit tests to the EXTCODE* series operations. Also, put all EVM operations tests in the proper package. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

add option for ephemery testnet

260b8f6

Signed-off-by: gconnect <agatevureglory@gmail.com>

add ephemery bootnodes to the ephemery.json genesis file

05da951

Signed-off-by: gconnect <agatevureglory@gmail.com>

Add test for ephemery

dd3ab09

Signed-off-by: gconnect <agatevureglory@gmail.com>

Format code with sportlessApply

4d678a4

Signed-off-by: gconnect <agatevureglory@gmail.com>

Add setNetworkId method and generateEphemeryGenesis

9e875ec

Signed-off-by: gconnect <agatevureglory@gmail.com>

bump execution-spec-tests, account for new name for main stable artif…

4c4b60a

…act (besu-eth#7380) Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

Disable bonsai-limit-trie-logs-enabled if sync-mode=FULL (besu-eth#7357)

edace71

There is still a startup error when bonsai-limit-trie-logs-enabled is explicitly set to true --------- Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>

Snap server GetTrieNodes to return empty bytes when trienode doesn't …

5521cb8

…exist (besu-eth#7305) Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>

kesrishubham2510 and others added 7 commits August 26, 2024 13:47

Fixed | Initialising the encodedPubKey with empty String in case user…

aa13cda

…Info is null (besu-eth#7508) Signed-off-by: kesrishubham2510 <shubhamkeshari90@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

update link (besu-eth#7506)

c0d237d

Signed-off-by: Neo <neowang725@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

Fix fuzzing dependencies (besu-eth#7519)

c3b47b0

The fuzzAll task depended on targets that didn't exist. Signed-off-by: Danno Ferrin <danno@numisight.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: gconnect <agatevureglory@gmail.com>

Format the NetworkName file and update the Ephemery comment

ef55bed

Signed-off-by: gconnect <agatevureglory@gmail.com>

gconnect force-pushed the add-network-support-for-ephemery-testnet branch from 4a45494 to ef55bed Compare August 26, 2024 12:48

Merge branch 'main' into add-network-support-for-ephemery-testnet

58aa97c

Signed-off-by: Glory Agatevure <agatevureglory@gmail.com>

gconnect added 4 commits August 27, 2024 14:17

Merge branch 'main' into add-network-support-for-ephemery-testnet

3dfadc6

Use genesisConfig overrides in the EphemeryGenesisFile and update the…

0a06caf

… test Signed-off-by: gconnect <agatevureglory@gmail.com>

Merge main into branch

d5a29f1

Signed-off-by: gconnect <agatevureglory@gmail.com>

Merge branch 'main' into add-network-support-for-ephemery-testnet

254f9ab

macfarla reviewed Aug 29, 2024

View reviewed changes

gconnect added 4 commits August 29, 2024 16:10

Merge branch 'main' into add-network-support-for-ephemery-testnet

e87b0c9

Update setNetworkId method, EphemeryGenesisFile and Update the test

16a3e76

Signed-off-by: gconnect <agatevureglory@gmail.com>

Remove check for genesisconfigfile

7cee24a

Merge main into branch

2027ff1

Signed-off-by: gconnect <agatevureglory@gmail.com>

gconnect force-pushed the add-network-support-for-ephemery-testnet branch from 36e1ce1 to 2027ff1 Compare August 30, 2024 05:12

gconnect added 6 commits August 30, 2024 06:13

Merge branch 'main' into add-network-support-for-ephemery-testnet

3c1290b

Merge branch 'main' into add-network-support-for-ephemery-testnet

28119c6

sign-off for commit 7cee24a

69c1b83

Signed-off-by: gconnect <agatevureglory@gmail.com>

Merge main intro branch

1cc3ad3

Signed-off-by: gconnect <agatevureglory@gmail.com>

Add comment to EphemeryGenesisFile

a53b92b

Signed-off-by: gconnect <agatevureglory@gmail.com>

Merge branch 'main' into add-network-support-for-ephemery-testnet

f45e8c4

gconnect closed this Sep 3, 2024

Conversation

gconnect commented Aug 16, 2024 • edited by macfarla Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

Locally, you can run these tests to catch failures early:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macfarla commented Aug 21, 2024

Uh oh!

gconnect commented Aug 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gconnect commented Aug 23, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gconnect commented Aug 26, 2024

Uh oh!

gconnect commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

macfarla left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macfarla Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

gconnect Aug 30, 2024

Choose a reason for hiding this comment

Uh oh!

gconnect commented Sep 3, 2024

Uh oh!

gconnect commented Sep 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

gconnect commented Aug 16, 2024 •

edited by macfarla

Loading

gconnect commented Aug 21, 2024 •

edited

Loading

gconnect commented Aug 28, 2024 •

edited

Loading