Remove address warmup while generating the targetContractAddress#7415
Merged
lu-pinto merged 2 commits intobesu-eth:mainfrom Aug 12, 2024
Conversation
lu-pinto
force-pushed
the
refactor-remove-warmup-address-while-generating-contract-address
branch
from
1e93414 to
de1d931
Compare
Contributor
|
Reference tests broke, in the create2 section. It's a hard no unless all reference tests pass. |
lu-pinto
force-pushed
the
refactor-remove-warmup-address-while-generating-contract-address
branch
from
de1d931 to
52ba334
Compare
…hod to createe frame Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
lu-pinto
force-pushed
the
refactor-remove-warmup-address-while-generating-contract-address
branch
from
52ba334 to
f1d5608
Compare
shemnon
approved these changes
Aug 1, 2024
Contributor
shemnon
left a comment
shemnon
left a comment
There was a problem hiding this comment.
LGTM, assuming there are no more changes needed to pass tests.
…ing-contract-address
lu-pinto
deleted the
refactor-remove-warmup-address-while-generating-contract-address
branch
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
…hod to createe frame (besu-eth#7415) Signed-off-by: Luis Pinto <luis.pinto@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Side-effect free change to remove unnecessary
warmUpAddresscall from the contract address generation, since that is already done while building the child frame for executing the init code of a contract shortly afterwards.Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests