Refactor TrieLogPruner preload timeout to be more testable#7393
Merged
siladu merged 5 commits intobesu-eth:mainfrom Jul 30, 2024
Merged
Refactor TrieLogPruner preload timeout to be more testable#7393siladu merged 5 commits intobesu-eth:mainfrom
siladu merged 5 commits intobesu-eth:mainfrom
Conversation
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
fab-10
approved these changes
Jul 29, 2024
Contributor
fab-10
left a comment
There was a problem hiding this comment.
you could also have used EthScheduler that has support for testing
macfarla
approved these changes
Jul 30, 2024
jframe
approved these changes
Jul 30, 2024
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
…7393) Also update logging Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An improved version of #7365
Example of INFO level logging during timeout...
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTestsSigned-off-by: Simon Dudley simon.dudley@consensys.net