[LOGGING] snap pipeline errors and peer reputation#6924
Merged
macfarla merged 16 commits intobesu-eth:mainfrom May 8, 2024
Merged
[LOGGING] snap pipeline errors and peer reputation#6924macfarla merged 16 commits intobesu-eth:mainfrom
macfarla merged 16 commits intobesu-eth:mainfrom
Conversation
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
macfarla
previously approved these changes
Apr 12, 2024
Contributor
|
maybe we want to throttle this, depending on how spammy it is? |
Contributor
|
going to test this on some nodes and see how spammy it is |
macfarla
added a commit
to pinges/besu
that referenced
this pull request
Apr 12, 2024
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Contributor
|
combined this with changes from #6831 |
macfarla
changed the title
Contributor
too spammy at info level. changed to debug. |
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
May 28, 2024
* add logs for snap errors Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * add logs for requests that are returning with errors Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * spotless Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * turn down the logging Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * transaction message sender logging Signed-off-by: Jason Frame <jason.frame@consensys.net> * log peer with peer reputation event Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * formatting Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Jason Frame <jason.frame@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
* add logs for snap errors Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * add logs for requests that are returning with errors Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * spotless Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * turn down the logging Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * transaction message sender logging Signed-off-by: Jason Frame <jason.frame@consensys.net> * log peer with peer reputation event Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * formatting Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Jason Frame <jason.frame@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Jason Frame <jason.frame@consensys.net>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jun 10, 2024
* add logs for snap errors Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * add logs for requests that are returning with errors Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * spotless Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * turn down the logging Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * transaction message sender logging Signed-off-by: Jason Frame <jason.frame@consensys.net> * log peer with peer reputation event Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * formatting Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Jason Frame <jason.frame@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests