proposed "develop" build versions#6699
Conversation
| } | ||
| return version | ||
| def gitDetails = getGitCommitDetails(10) // Adjust length as needed | ||
| return "${gitDetails.date}-develop-${gitDetails.hash}" |
There was a problem hiding this comment.
@jflo thinking about the impact of this on docker builds. we would probably have a build explosion if we published versions like this on dockerhub. Does the new CI pipeline explicitly push versions into snapshot builds on main ? or is that something we need to account for here?
There was a problem hiding this comment.
I disabled the duplicate circle-ci workflows in this PR that are causing us to publish docker images to dockerhub using snapshot build tags
There was a problem hiding this comment.
reverted the change in favor of just disabling the circle-ci webhook
There was a problem hiding this comment.
We no longer push interim builds on every push to main. Nobody uses them, so they were a waste of cycles and space. This should be safe.
There was a problem hiding this comment.
you can still have build artifacts, just not docker images: https://github.com/hyperledger/besu/releases/tag/develop
garyschulte
force-pushed
the
feature/dynamic-build-version
branch
2 times, most recently
from
ecb9e65 to
e7e4185
Compare
jflo
left a comment
jflo
left a comment
There was a problem hiding this comment.
Love it, but we do need to still honor -Pversion when it is used by the release pipeline.
| apply plugin: 'net.ltgt.errorprone' | ||
| apply from: "${rootDir}/gradle/versions.gradle" | ||
|
|
||
| version = rootProject.version |
There was a problem hiding this comment.
this would keep us from being able to inject the release version we want via -Pversion=${{github.ref_name}} so we need to only use calculateVersion if that isn't set.
There was a problem hiding this comment.
added a provision for build version to be supplied 👍 . I also force it to be semver or semver-something
| } | ||
| return version | ||
| def gitDetails = getGitCommitDetails(10) // Adjust length as needed | ||
| return "${gitDetails.date}-develop-${gitDetails.hash}" |
There was a problem hiding this comment.
We no longer push interim builds on every push to main. Nobody uses them, so they were a waste of cycles and space. This should be safe.
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/dynamic-build-version
branch
from
2b25b38 to
dcce662
Compare
…r than 24.3.13-develop-dcce662e8c Signed-off-by: garyschulte <garyschulte@gmail.com>
* proposed "develop" build versions Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
* proposed "develop" build versions Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
* proposed "develop" build versions Signed-off-by: garyschulte <garyschulte@gmail.com>
3 participants
PR description
As part of our recent build and release changes, we no longer need to explicitly maintain the build version in gradle.properties file.
This PR is a proposal to change our "develop" builds to use git commit and HEAD details to specify a dynamic build version.
for example this PR, prior to committing the changes, produced a build named:
besu-24.3.7-develop-610927511e.tar.gzAfter committing the gradle changes and rebuilding, it produced a build named:
besu-24.3.7-develop-600d812d89.tar.gzOpen to suggestions, feedback, and identifying corner cases
Fixed Issue(s)