Skip to content

cliqueBft AT task flakiness - extend no_output_timeout#6406

Merged
macfarla merged 3 commits intobesu-eth:mainfrom
macfarla:clique-ats-xl-machine
Jan 16, 2024
Merged

cliqueBft AT task flakiness - extend no_output_timeout#6406
macfarla merged 3 commits intobesu-eth:mainfrom
macfarla:clique-ats-xl-machine

Conversation

@macfarla
Copy link
Copy Markdown
Contributor

@macfarla macfarla commented Jan 15, 2024 •
edited
Loading

@macfarla
revert besu-eth#6392 back to xl machine executor
ab31105 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 15, 2024

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@jframe
Copy link
Copy Markdown
Contributor

jframe commented Jan 15, 2024

Could also just increase the no_output_timeout. I increased it to 25m in my PR as kept failing with the 20m it has right now. Might be better than increasing the machine executor size.

@macfarla
revert machine change and extend timeout instead
437fdfb 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla changed the title cliqueBft ATs - revert back to xl machine executor cliqueBft AT task flakiness - extend no_output_timeout Jan 15, 2024
@macfarla macfarla enabled auto-merge (squash) January 16, 2024 00:53
jframe
jframe approved these changes Jan 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla merged commit 2c1d3d2 into besu-eth:main Jan 16, 2024
@macfarla macfarla deleted the clique-ats-xl-machine branch January 16, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jframe jframe jframe approved these changes

Assignees

No one assigned

Labels

testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@macfarla @jframe