Skip to content

consensus/common migrate to junit5#6233

Closed
macfarla wants to merge 12 commits intobesu-eth:mainfrom
macfarla:common-junit-5
Closed

consensus/common migrate to junit5#6233
macfarla wants to merge 12 commits intobesu-eth:mainfrom
macfarla:common-junit-5

Conversation

@macfarla
Copy link
Copy Markdown
Contributor

@macfarla macfarla commented Dec 5, 2023

fixes #5569

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla changed the title consensys/common migrate to junit5 consensus/common migrate to junit5 Dec 5, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 5, 2023

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

delehef and others added 6 commits December 6, 2023 09:06
Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Copy link
Copy Markdown
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Copy link
Copy Markdown
Contributor Author

macfarla commented Dec 7, 2023

closing in favour of #6253

@macfarla macfarla closed this Dec 7, 2023
@macfarla macfarla deleted the common-junit-5 branch December 14, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

consensus - migrate tests from Junit4 to Junit5

4 participants