Use PendingTransaction in BlockTransactionSelector#5966
Merged
fab-10 merged 1 commit intobesu-eth:mainfrom Oct 2, 2023
Merged
Conversation
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * and deciding which transactions to drop when the transaction pool reaches its size limit. | ||
| */ | ||
| public abstract class PendingTransaction { | ||
| public abstract class PendingTransaction |
Check notice
Code scanning / CodeQL
Class has same name as super class
fab-10
force-pushed
the
tx-selector-pending-tx
branch
from
7d1bcf1 to
68cbc2c
Compare
Merged
Gabriel-Trintinalia
approved these changes
Oct 1, 2023
Contributor
Gabriel-Trintinalia
left a comment
Gabriel-Trintinalia
left a comment
There was a problem hiding this comment.
LGTM, I am wondering if it makes sense to have it named PooledTransaction instead of PendingTransaction, since PendingTransaction are transactions that are in the transaction pool and not confirmed yet. That would also match the methods GetPooledTransactions and NewPooledTransactionHashes as well as the EncodingContext in the transaction encoder
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
tx-selector-pending-tx
branch
from
68cbc2c to
5e62c01
Compare
Contributor
Author
|
@Gabriel-Trintinalia it seems that pending and pooled are both used as synonyms, here for example, but I have no objections if you want to evaluate a renaming |
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 10, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us>
NickSneo
pushed a commit
to NickSneo/besu
that referenced
this pull request
Nov 12, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
This is just a refactoring, no functionality change, to have the
PendingTransactionobject during the selection of transactions, since in thePendingTransactionthere are additional metadata about the candidate transaction that can be used by the selection process, and more will be added in a next PR to better support priority senders.