Skip to content

copy layered worldstate fix for eth_call#5179

Merged
garyschulte merged 4 commits into
besu-eth:mainfrom
garyschulte:bugfix/eth_call
Mar 7, 2023
Merged

copy layered worldstate fix for eth_call#5179
garyschulte merged 4 commits into
besu-eth:mainfrom
garyschulte:bugfix/eth_call

Conversation

@garyschulte

@garyschulte garyschulte commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

PR description

This is mitigation fix for eth_call concurrency failures, similar to #5076.

This mitigation will be obseleted by #5123.

Fixed Issue(s)

#5175

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Acceptance Tests (Non Mainnet)

  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.

Changelog

Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
@matkt

matkt commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

Tested with @ahamlat . Ethcall fails 1/3 times without the fix and with the fix it works every time so LGTM

@matkt matkt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garyschulte garyschulte enabled auto-merge (squash) March 7, 2023 15:28
@garyschulte garyschulte merged commit da477e9 into besu-eth:main Mar 7, 2023
garyschulte added a commit to garyschulte/besu that referenced this pull request Apr 10, 2023
* copy layered worldstate fix for eth_call

Signed-off-by: garyschulte <garyschulte@gmail.com>
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
* copy layered worldstate fix for eth_call

Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
* copy layered worldstate fix for eth_call

Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte deleted the bugfix/eth_call branch January 24, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants