Disable RocksDB checksum verification on reads#5042
Merged
Conversation
…ocksDB get methods Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
…sDB reads Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Feb 5, 2023
* Add RocksDB readOptions with checksum verification set to false for RocksDB get methods * Spotless + apply disabling checksum verification for unsegmented RocksDB reads Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Feb 5, 2023
* Add RocksDB readOptions with checksum verification set to false for RocksDB get methods * Spotless + apply disabling checksum verification for unsegmented RocksDB reads Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us>
shemnon
pushed a commit
to shemnon/besu
that referenced
this pull request
Feb 8, 2023
* Add RocksDB readOptions with checksum verification set to false for RocksDB get methods * Spotless + apply disabling checksum verification for unsegmented RocksDB reads Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
ensi321
pushed a commit
to ensi321/besu
that referenced
this pull request
Feb 19, 2023
* Add RocksDB readOptions with checksum verification set to false for RocksDB get methods * Spotless + apply disabling checksum verification for unsegmented RocksDB reads Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
* Add RocksDB readOptions with checksum verification set to false for RocksDB get methods * Spotless + apply disabling checksum verification for unsegmented RocksDB reads Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Add RocksDB readOptions with checksum verification set to false for RocksDB get methods * Spotless + apply disabling checksum verification for unsegmented RocksDB reads Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ameziane H ameziane.hamlat@consensys.net
PR description
This PR will disable checksum verification on RocksDB during Block retrieva.
We could't do it before because there is this issue in RocksDB, you can find more context here : facebook/rocksdb#11002
@matkt did a PR facebook/rocksdb#11099 and fixed the issue, we can now enable it in Besu.
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog