PoS checkpoint sync#4844
Merged
Merged
Conversation
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
…troller Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
siladu
reviewed
Dec 20, 2022
jframe
reviewed
Dec 21, 2022
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
jframe
approved these changes
Dec 21, 2022
gfukushima
enabled auto-merge (squash)
December 21, 2022 04:00
This was referenced Dec 21, 2022
Closed
matkt
reviewed
Dec 21, 2022
| .isPresent()); | ||
| } | ||
|
|
||
| private void validatePostMergeCheckpointBlockRequirements() { |
Contributor
There was a problem hiding this comment.
why all of this check are not in the valid method of CheckpointConfigOptions ?
| } | ||
|
|
||
| private boolean isCheckpointPoSBlock(final GenesisConfigOptions configOptions) { | ||
| final UInt256 terminalTotalDifficulty = configOptions.getTerminalTotalDifficulty().get(); |
Contributor
There was a problem hiding this comment.
I think we cannot have empty here ?
| private boolean isCheckpointPoSBlock(final GenesisConfigOptions configOptions) { | ||
| final UInt256 terminalTotalDifficulty = configOptions.getTerminalTotalDifficulty().get(); | ||
|
|
||
| return configOptions.getCheckpointOptions().isValid() |
Contributor
There was a problem hiding this comment.
we are not already checking if it is valid here ? https://github.com/hyperledger/besu/pull/4844/files#diff-2080ac0bf38c1e492921f4191b738b729195e0b1ad82657abc9103f19ac87cd8R3368
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 22, 2022
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Jan 10, 2023
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Enables PoS checkpoint sync under an experimental flag
Fixed Issue(s)
Fixes #4573
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog