Skip to content

Docker release task for latest tags#4810

Merged
jframe merged 11 commits into
besu-eth:mainfrom
jframe:docker_release_tag_fixes
Dec 14, 2022
Merged

Docker release task for latest tags#4810
jframe merged 11 commits into
besu-eth:mainfrom
jframe:docker_release_tag_fixes

Conversation

@jframe

@jframe jframe commented Dec 13, 2022

Copy link
Copy Markdown
Contributor

PR description

Expands the github release workflow to support adding the latest tags for all the docker variants and architectures.

  • Replace the use of git sha tags with existing release tags to avoid creating a lot of unneeded tags. When creating the latest tags for all the variants, arch and manifests 15 tags are needed in total
  • Added latest tags for variants as was done for previous releases
  • Added latest tags for all the architectures
  • Added latest tags for multi-arch images

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

…ker image to be built again

Signed-off-by: Jason Frame <jason.frame@consensys.net>
…r tasks

Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe jframe changed the title Docker release tasks Besu release task for multi-arch latest tags Dec 13, 2022
@jframe jframe changed the title Besu release task for multi-arch latest tags Besu release task for latest tags Dec 13, 2022
@jframe
jframe marked this pull request as ready for review December 13, 2022 08:08
This reverts commit 2c1af25.

Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe jframe changed the title Besu release task for latest tags Docker release task for latest tags Dec 13, 2022
@jflo

jflo commented Dec 13, 2022

Copy link
Copy Markdown
Contributor

This is a different approach, but certainly viable. Using this release action, we would still require a build to be run and the release tag to be applied so that it can be promoted. The previous approach allowed for promoting a snapshot.

Both approaches allow us to iterate on an image and defer application of the latest tag till when the release is cut.

@jframe

jframe commented Dec 13, 2022

Copy link
Copy Markdown
Contributor Author

This is a different approach, but certainly viable. Using this release action, we would still require a build to be run and the release tag to be applied so that it can be promoted. The previous approach allowed for promoting a snapshot.

Both approaches allow us to iterate on an image and defer application of the latest tag till when the release is cut.

This approach doesn't require a build to be run. It does a docker pull to retrieve the image on the docker registry before applying the tags and pushing them.

But it wouldn't work on promoting a snapshot we can't identity a specific build for the snapshot. So using the sha would be a benefit if wanted to keep that ability.

@jframe
jframe requested review from garyschulte and jflo December 14, 2022 01:32
@jframe
jframe merged commit 406a069 into besu-eth:main Dec 14, 2022
@jframe
jframe deleted the docker_release_tag_fixes branch December 14, 2022 21:25
jframe added a commit to jframe/besu that referenced this pull request Dec 16, 2022
Signed-off-by: Jason Frame <jason.frame@consensys.net>
jframe added a commit that referenced this pull request Dec 16, 2022
Signed-off-by: Jason Frame <jason.frame@consensys.net>
ahamlat pushed a commit to ahamlat/besu that referenced this pull request Dec 18, 2022
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
jflo pushed a commit to jflo/besu that referenced this pull request Dec 22, 2022
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
macfarla pushed a commit to macfarla/besu that referenced this pull request Jan 10, 2023
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants