Skip to content

merge Parallelize calculate root hash into RC3#4590

Merged
garyschulte merged 1 commit intobesu-eth:release-22.10.xfrom
garyschulte:parallelize-calculateRootHash
Nov 2, 2022
Merged

merge Parallelize calculate root hash into RC3#4590
garyschulte merged 1 commit intobesu-eth:release-22.10.xfrom
garyschulte:parallelize-calculateRootHash

Conversation

@garyschulte
Copy link
Copy Markdown
Contributor

@garyschulte garyschulte commented Nov 2, 2022

PR description

This PR essentially makes the release-22.10.x branch the same as main with #4568 merged into it

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

@garyschulte garyschulte force-pushed the parallelize-calculateRootHash branch from 9a9cb0b to e890f89 Compare November 2, 2022 03:08
@garyschulte garyschulte marked this pull request as ready for review November 2, 2022 03:11
@garyschulte garyschulte force-pushed the parallelize-calculateRootHash branch 2 times, most recently from 112aa8a to 1f34dc2 Compare November 2, 2022 04:16
// we don't have that block
throw new GraphQLException(GraphQLError.CHAIN_HEAD_WORLD_STATE_NOT_AVAILABLE);
}
});
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't expecting GraphQL changes in this merge

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh it's the getAndMapWorldState change

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, those are from the snapshot bonsai PR that merged to main. The version of the snapshot pr that was originally in rc3 did not have those changes

Comment thread gradle.properties Outdated
@@ -1,4 +1,4 @@
version=22.10.0-RC3-SNAPSHOT
version=22.10.0-SNAPSHOT
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we doing this already

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks

Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte force-pushed the parallelize-calculateRootHash branch from 1f34dc2 to 20067d1 Compare November 2, 2022 04:50
Copy link
Copy Markdown
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garyschulte garyschulte enabled auto-merge (squash) November 2, 2022 04:52
@garyschulte garyschulte merged commit a13ef11 into besu-eth:release-22.10.x Nov 2, 2022
@garyschulte garyschulte deleted the parallelize-calculateRootHash branch November 2, 2022 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants