Skip to content

Refactoring of calculate root hash#4551

Closed
gezero wants to merge 4 commits intobesu-eth:mainfrom
gezero:extract-methods-from-calculate-root-hash
Closed

Refactoring of calculate root hash#4551
gezero wants to merge 4 commits intobesu-eth:mainfrom
gezero:extract-methods-from-calculate-root-hash

Conversation

@gezero
Copy link
Copy Markdown
Contributor

@gezero gezero commented Oct 22, 2022

Small refactoring of the calculate root hash.

The second commit fixes a tiny bug where we leave a few insignificant nodes in the trie branch storage.

gezero and others added 4 commits October 22, 2022 11:46
To properly measure performance and differences between parts of the methods we extract parts of it.

Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
The algorithm would leave few nodes in the trie branch storage in its last iteration

Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
@macfarla
Copy link
Copy Markdown
Contributor

macfarla commented Nov 3, 2022

this is already merged in as part of #4568 so we can close this one, right @gezero ?

@macfarla macfarla closed this Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants