Implement Phoenix EVM and Protocol Upgrades#434
Conversation
Signed-off-by: Edward Mack <ed@edwardmack.com>
Signed-off-by: Edward Mack <ed@edwardmack.com>
Implement Phoenix EVM and protocol upgrades as per ECIP-1088 Signed-off-by: Edward Mack <ed@edwardmack.com>
Signed-off-by: /raw PONG _GHMoaCXLT <58883403+q9f@users.noreply.github.com>
| .contractCreationProcessorBuilder( | ||
| (gasCalculator, evm) -> | ||
| new MainnetContractCreationProcessor( | ||
| gasCalculator, | ||
| evm, | ||
| true, | ||
| Collections.singletonList(MaxCodeSizeRule.of(contractSizeLimit)), | ||
| 1)) |
There was a problem hiding this comment.
This appears to be identical to the definition already inherited from Atlantis. Am I missing something, should something have changed or is this just not required?
There was a problem hiding this comment.
This is indeed the same as Atlantis. If this isn't specified here, will it automatically use the previous one defined?
There was a problem hiding this comment.
Yes. You should only need to specify the changes between each milestone. So the only time you'd have two milestones with the same declaration is if something changed and then changed back (you'd have to override the changed version back to the original).
There was a problem hiding this comment.
Ok, this makes sense, I didn't think in was required, but I was following the pattern in MainnetProtocolSpec where contractCreationProcessBuilder is defined for SpuriouDragon then with the same definition for Istanbul without any changes is between. I wasn't sure why that was done, but I followed that pattern. I'll remove it from Phoenix since it has already been defined.
lucassaldanha
left a comment
lucassaldanha
left a comment
There was a problem hiding this comment.
Given that the contractCreationProcessorBuilder definition for Phoenix is exactly the same as the previously defined in Atlantis, we don't need to specify it again.
remove unnecessary contractCreationProcessorBuilder from Phoenix ClassicProtocolSpec. Signed-off-by: Edward Mack <ed@edwardmack.com>
|
I've updated this, should be all set now. |
4 participants
PR description
This PR implements EVM and Protocol upgrades as outlined in ECIP 1088 https://ecips.ethereumclassic.org/ECIPs/ecip-1088
Fixed Issue(s)