Automatically cache Transaction Log Bloom Filters#413
Merged
Conversation
* First iteration. Draft PR. Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * fix SPDX header Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Use block broadcaster to index log bloom. Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Remove useless toString method Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * spotless apply Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * cacheLogsBloomForBlockHeader Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * spotless apply Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * ensurePreviousSegmentsArePresent Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Added CLI flag to enable / disable automatic logs bloom indexing. Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Create cache directory and cache file if not exist. Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Fix acceptance test Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Write cache for block only if block is new canonical head. Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Handling of chain reorg. Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * fix Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * sportless apply Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Address PR comments. Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Remove unused constant. Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * spotless apply Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> (cherry picked from commit 6677362) Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
besu-eth#407) * Don't use pending file. Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Don't use pending file. Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> (cherry picked from commit c38152a) Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Make sure we cache the current cache segment with all of the data from the beginning of the segment. Use a flip file approach since it will be a partial file until done. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new option
--auto-logs-bloom-indexing-enabledwhich defaults to true. This performs the equivalent of theoperator generate-log-bloom-cacheCLI task oradmin_generateLogBloomCacheRPC call for each block as it arrives, in addition to caching older logs on first startup.