EIP2384 - Ice Age Adustment around Istanbul#211
Merged
shemnon merged 10 commits intobesu-eth:masterfrom Dec 4, 2019
Merged
Conversation
Add support for EIP2384 * Current placeholder is "EIP2384Block" because Icestanbul seemed a little too silly. * Add difficulty calculator tests from the reference tests Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
* update to new name * add fork block numbers * update reference tests Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> # Conflicts: # config/src/test-support/java/org/hyperledger/besu/config/StubGenesisConfigOptions.java
Contributor
|
Icestanbul is an amazing name. |
RatanRSur
reviewed
Dec 2, 2019
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
https: //gitter.im/ethereum/AllCoreDevs?at=5de7b410d64a052fb6b3fa8d Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
RatanRSur
reviewed
Dec 4, 2019
| (time, parent, protocolContext) -> | ||
| calculateThawedDifficulty(time, parent, MUIR_GLACIER_FAKE_BLOCK_OFFSET); | ||
|
|
||
| private static BigInteger calculateThawedDifficulty( |
Contributor
There was a problem hiding this comment.
Could this be calculateMuirGlacierDifficulty? As it is it seems like it reduces code discoverability if you're searching for instances of the hard fork, like you could have when it was Byzantium?
Contributor
Author
There was a problem hiding this comment.
It's used in 3 different places, Byzantium, Constantinople, and now MuirGlacier. Before it was calculageByzantiumDifficulty.
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
RatanRSur
reviewed
Dec 4, 2019
| } | ||
|
|
||
| @Test | ||
| public void testDifficultyCalculation() throws IOException { |
Contributor
There was a problem hiding this comment.
Can this test not be run in isolation? Getting NullPointerExceptions when running this alone through intellij. Is there a gradle task that downloads resources?
Contributor
Author
There was a problem hiding this comment.
How many, if its 3 NPEs You need to update your submodules, if it's more you need to run it via gradle or have IntelliJ add the reference tests resoureces to the classpath when running.
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
RatanRSur
approved these changes
Dec 4, 2019
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
Add support for MuirGlacier * Add block numbers for Ropsten and Mainnet * Add reference tests for difficulty calculations * Update reference tests for new MuirGlacier difficulty tests Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
Add support for MuirGlacier * Add block numbers for Ropsten and Mainnet * Add reference tests for difficulty calculations * Update reference tests for new MuirGlacier difficulty tests Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Signed-off-by: edwardmack <ed@edwardmack.com>
siladu
pushed a commit
to siladu/besu
that referenced
this pull request
Oct 28, 2024
Engine API: respond with error if payload attributes are invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for EIP2384
little too silly.
(ethereum/EIPs#2384)
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>