Skip to content

[PAN-3202][BESU-37] Implement EIP-2124#156

Merged
RatanRSur merged 59 commits into
besu-eth:masterfrom
SteveMieskoski:eip-2124
Jan 10, 2020
Merged

[PAN-3202][BESU-37] Implement EIP-2124#156
RatanRSur merged 59 commits into
besu-eth:masterfrom
SteveMieskoski:eip-2124

Conversation

@SteveMieskoski
Copy link
Copy Markdown
Contributor

@SteveMieskoski SteveMieskoski commented Nov 4, 2019 •
edited
Loading

#156 [PAN-3202] Implement EIP-2124

  • Collect list of forks for creation of EIP-2124 fork hashes

  • Implement creation of fork hashes for related to EIP-2124

  • Provide mechanism to check the fork hash of a peer

  • Note: see issue comments for additional details.

@shemnon
Copy link
Copy Markdown
Contributor

shemnon commented Nov 4, 2019

Build is failing because of formatting.

./gradlew spotlessApply

run this and commit the diffs.

@shemnon
Copy link
Copy Markdown
Contributor

shemnon commented Nov 5, 2019

DCO bot is unhappy now - https://github.com/hyperledger/besu/pull/156/checks?check_run_id=288832044

For my IDE (IntelliJ( I just turned on a flag that always adds DCOs to my commits

macfarla and others added 10 commits November 5, 2019 10:38
@macfarla @SteveMieskoski
edits to test names (besu-eth#153)
5db0202 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: SteveM <SteveM@myEtherWallet.com>
@CjHare @SteveMieskoski
Moving JsonRpcMethods classes into the same package, prior to refactor (
3ac0ef5 
besu-eth#154)

Signed-off-by: Christopher Hare <chris.hare@consensys.net>
Signed-off-by: SteveM <SteveM@myEtherWallet.com>
@shemnon @SteveMieskoski
Add --identity flag for client identification in node browsers (besu-…
a416b4e 
…eth#150)

Support the "--identity" flag.  This adds a fifth field to the normally 
four part clientId, with the identity in the second position.

For example, if the CLI flag "--identity PegaSysEng" were passed in the
clientID reported by ethernodes would read

`besu/PegaSysEng/v1.3.2/linux-x86_64/oracle_openjdk-java-11`

Whereas without the flag it would just read

`besu/v1.3.2/linux-x86_64/oracle_openjdk-java-11`

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: SteveM <SteveM@myEtherWallet.com>
@SteveMieskoski
[PAN-3202] add basic forkId (eip-2124) creation class and related test
a26c73e 
Signed-off-by: SteveM <SteveM@myEtherWallet.com>
@RatanRSur @SteveMieskoski
[PAN-2798] Enable pruning by default for fast sync (besu-eth#135)
7e38ff5 
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: SteveM <SteveM@myEtherWallet.com>
@joshuafernandes @SteveMieskoski
commenting out circles publish on the release branch so we're ready f…
5349e18 
…or the release tomorrow and dont have jenkins & circle attempting to publish (besu-eth#157)

Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net>
Signed-off-by: SteveM <SteveM@myEtherWallet.com>
@SteveMieskoski
fix style to properly conform
46329a2 
Signed-off-by: SteveM <SteveM@myEtherWallet.com>
@CjHare @SteveMieskoski
Redesign of how JsonRpcMethods are created (besu-eth#159)
32ca662 
Signed-off-by: Christopher Hare <chris.hare@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: SteveM <SteveM@myEtherWallet.com>
@SteveMieskoski
remove print statement from forkId
b89494f 
Signed-off-by: SteveM <SteveM@myEtherWallet.com>
@SteveMieskoski
check protocol version and bypass at present until eth protocol with …
138d030 
…forkId announced

Signed-off-by: SteveM <SteveM@myEtherWallet.com>
@SteveMieskoski
Copy link
Copy Markdown
Contributor Author

SteveMieskoski commented Nov 5, 2019

Thanks, I see the option now.

shemnon
shemnon reviewed Nov 5, 2019
View reviewed changes
Comment thread ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/ForkId.java Outdated
@SteveMieskoski SteveMieskoski changed the title [PAN-3202] Implement EIP-2124 [PAN-3202][BESU-37] Implement EIP-2124 Nov 11, 2019
@RatanRSur
Copy link
Copy Markdown
Contributor

RatanRSur commented Nov 12, 2019

Thanks for the contribution! Taking a look at it now and I'll leave some comments.

RatanRSur
RatanRSur reviewed Nov 15, 2019
View reviewed changes
Comment thread ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/ForkId.java Outdated
RatanRSur
RatanRSur reviewed Nov 15, 2019
View reviewed changes
Comment thread ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/ForkId.java Outdated
RatanRSur
RatanRSur reviewed Nov 15, 2019
View reviewed changes
Comment thread ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/ForkId.java Outdated
RatanRSur
RatanRSur reviewed Nov 15, 2019
View reviewed changes
Comment thread ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/ForkId.java Outdated
RatanRSur
RatanRSur reviewed Nov 15, 2019
View reviewed changes
Comment thread ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/ForkId.java Outdated
@SteveMieskoski
Merge branch 'master' into eip-2124
65e66d3
@SteveMieskoski
change forkId to forkIdManager, idEntry to ForkId, modify statusMessa…
1882dcb 
…ge class to accept forkId, and use bytesValue instead of string within forkId

Signed-off-by: SteveM <SteveM@myEtherWallet.com>
RatanRSur
RatanRSur reviewed Nov 18, 2019
View reviewed changes
Comment thread besu/src/main/java/org/hyperledger/besu/controller/BesuControllerBuilder.java Outdated
RatanRSur
RatanRSur reviewed Nov 18, 2019
View reviewed changes
Comment thread ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/ForkId.java Outdated
SteveMieskoski and others added 6 commits December 12, 2019 08:47
@RatanRSur
Copy link
Copy Markdown
Contributor

RatanRSur commented Jan 8, 2020

@SteveMieskoski I'm good with you merging this when you are :)

@SteveMieskoski
Copy link
Copy Markdown
Contributor Author

SteveMieskoski commented Jan 8, 2020

@RatanRSur sounds good to me. I'm taking a moment right now to fix the ci errors, and then it should be good to go.

@SteveMieskoski
Copy link
Copy Markdown
Contributor Author

SteveMieskoski commented Jan 9, 2020

@RatanRSur everything seems good to go now :)

@RatanRSur RatanRSur merged commit ef61b54 into besu-eth:master Jan 10, 2020
edwardmack pushed a commit to ChainSafe/besu that referenced this pull request Feb 4, 2020
@SteveMieskoski @macfarla
@CjHare @shemnon @RatanRSur @joshuafernandes @edwardmack
[PAN-3202][BESU-37] Implement EIP-2124 (besu-eth#156)
0a0758d 
Signed-off-by: SteveM <SteveM@myEtherWallet.com>

Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Co-authored-by: CJ Hare <CjHare@users.noreply.github.com>
Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com>
Co-authored-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Co-authored-by: Joshua Fernandes <joshua.fernandes@consensys.net>
edwardmack pushed a commit to ChainSafe/besu that referenced this pull request Feb 4, 2020
@SteveMieskoski @macfarla
@CjHare @shemnon @RatanRSur @joshuafernandes @edwardmack
[PAN-3202][BESU-37] Implement EIP-2124 (besu-eth#156)
c829fdf 
Signed-off-by: SteveM <SteveM@myEtherWallet.com>

Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Co-authored-by: CJ Hare <CjHare@users.noreply.github.com>
Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com>
Co-authored-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Co-authored-by: Joshua Fernandes <joshua.fernandes@consensys.net>
Signed-off-by: edwardmack <ed@edwardmack.com>
@timbeiko timbeiko mentioned this pull request Mar 25, 2020
Closed
This was referenced Feb 22, 2022
Closed
Closed
@hardice501 hardice501 mentioned this pull request Jul 5, 2023
Closed
siladu pushed a commit to siladu/besu that referenced this pull request Oct 28, 2024
@lightclient
Merge pull request besu-eth#156 from shanejonas/patch-2
72a712a 
Add output of ref'd openrpc document for other consumers
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Mar 4, 2025
@kevaundray
ipa-multipoint : Updates rust-verkle dependency (besu-eth#156)
b445963 
updates the rust verkle dependency to the latest version and modifies the code to match.
- PedersenHash has changed internally to use MapToScalarField
- Methods now take a context and not a committer to make calling them easier.

---------

Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@shemnon shemnon shemnon left review comments

@RatanRSur RatanRSur RatanRSur approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SteveMieskoski @shemnon @RatanRSur @macfarla @CjHare @joshuafernandes