Skip to content

Remove resolved perf-check TODOs from UInt256 shift helpers #10406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
parthdagia05 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove resolved perf-check TODOs from UInt256 shift helpers #10406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions evm/src/main/java/org/hyperledger/besu/evm/UInt256.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,6 @@ public UInt256 shr(final UInt256 shift) {
* @param fill value to prepend while shifting
* @return the result
*/
// TODO: check perf - wiring shiftRight callers with this one
private UInt256 sar0(final int shift, final long fill) {
long w3 = u3, w2 = u2, w1 = u1, w0 = u0;
if (shift == 256) {
Expand Down Expand Up @@ -781,7 +780,6 @@ public UInt256 shl(final UInt256 shift) {
* @param shift number of bits to shift
* @return the result
*/
// TODO: check perf - wiring shiftLeft callers with this one
private UInt256 shl0(final int shift) {
long w3 = u3, w2 = u2, w1 = u1, w0 = u0;
if (shift == 256) {
Expand Down