feat: implement AddOperationV2 with long[] carry-propagated addition#10143
Closed
parthdagia05 wants to merge 3 commits intobesu-eth:mainfrom
Closed
feat: implement AddOperationV2 with long[] carry-propagated addition#10143parthdagia05 wants to merge 3 commits intobesu-eth:mainfrom
parthdagia05 wants to merge 3 commits intobesu-eth:mainfrom
Conversation
Signed-off-by: Parth Dagia <parth.24bcs10414@sst.scaler.com>
Author
|
@siladu can you review this PR |
siladu
reviewed
Apr 1, 2026
Author
There was a problem hiding this comment.
The file MulOperationOptimized.java has a trailing space in its filename . On Windows, git can't checkout files with trailing spaces, so it was automatically marked as deleted and got included in my commit unintentionally. I've restored it in the latest push. The trailing space in the upstream filename may need to be fixed separately to avoid this issue for other Windows contributors.
Author
There was a problem hiding this comment.
I've addressed the requested changes, Please take another look.
Author
…s trailing-space limitation Signed-off-by: Parth Dagia <parth.24bcs10414@sst.scaler.com>
Contributor
|
Closing as discussed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Issue(s)
Partial fix for #10131
Description
Implements
AddOperationV2.staticOperation()that was stubbed in #10105. Performs 256-bit addition directly on thelong[]stack with carry propagation across 4 limbs. Zero object allocation per operation.Motivation
The previous implementation was a stub that threw
UnsupportedOperationException, preventing execution paths from using this operation. This change enables efficient 256-bit addition aligned with EVM design goals of low-level, allocation-free execution.Summary
AddOperationV2.staticOperation()long[]with carry propagation across 4 limbsChecklist
Tests run locally
./gradlew spotlessApply./gradlew :evm:compileJava./gradlew :evm:testNotes
Part of #10131