Skip to content

DetermineCommonAncestor: reduce number of scenarios tested #10055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macfarla merged 2 commits into from
Mar 17, 2026
Merged

DetermineCommonAncestor: reduce number of scenarios tested #10055

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2aeb9fd
reduce number of scenarios tested
macfarla Mar 16, 2026
fcdd74f
Merge branch 'main' into determine-common-ancestor-test-reduce
macfarla Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions ...yperledger/besu/ethereum/eth/sync/tasks/DetermineCommonAncestorTaskParameterizedTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,10 @@
import org.hyperledger.besu.plugin.services.MetricsSystem;

import java.util.ArrayList;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Optional;
import java.util.Set;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicReference;
Expand Down Expand Up @@ -102,9 +104,24 @@ public static Stream<Arguments> parameters() {
final int[] requestSizes = {5, 12, chainHeight, chainHeight * 2};
final Stream.Builder<Arguments> builder = Stream.builder();
for (final int requestSize : requestSizes) {
for (int i = 0; i <= chainHeight; i++) {
builder.add(Arguments.of(requestSize, i));
// Test boundary-sensitive heights rather than every height 0..chainHeight.
// The algorithm batches headers in groups of requestSize, so only heights at
// batch boundaries (and their neighbours) exercise different code paths.
final Set<Integer> heights = new LinkedHashSet<>();
heights.add(0);
heights.add(1);
heights.add(chainHeight / 2);
heights.add(chainHeight - 1);
heights.add(chainHeight);
for (int boundary = requestSize; boundary < chainHeight; boundary += requestSize) {
heights.add(boundary - 1);
heights.add(boundary);
heights.add(boundary + 1);
}
heights.stream()
.filter(h -> h >= 0 && h <= chainHeight)
.sorted()
.forEach(h -> builder.add(Arguments.of(requestSize, h)));
}
return builder.build();
}
Expand Down
Loading