Skip to content

snap - diagnostic logging for malformed RLP messages #10038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macfarla merged 3 commits into from
Mar 17, 2026
Merged

snap - diagnostic logging for malformed RLP messages #10038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dccd127
logging improvements for breach of protocol for rlp
macfarla Mar 12, 2026
9444dcd
Merge branch 'main' of github.com:hyperledger/besu into rlp-malformed…
macfarla Mar 12, 2026
9c6a769
Merge branch 'main' into rlp-malformed-logging
pinges Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/EthProtocolManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,10 +315,12 @@ public void processMessage(final Capability capability, final Message message) {
}
} catch (final RLPException e) {
LOG.atDebug()
.setMessage("Received malformed message {} (BREACH_OF_PROTOCOL), disconnecting: {}, {}")
.setMessage(
"Received malformed message code={} data={} (BREACH_OF_PROTOCOL), disconnecting: {}")
.addArgument(code)
.addArgument(messageData::getData)
.addArgument(ethPeer::toString)
.addArgument(e::toString)
.setCause(e)
.log();

ethPeer.disconnect(
Expand Down
3 changes: 2 additions & 1 deletion ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/RequestManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ public void dispatchResponse(final EthMessage ethMessage) {
() -> peer.recordUselessResponse("Request ID incorrect"));
} catch (final RLPException e) {
LOG.debug(
"Received malformed message {} (BREACH_OF_PROTOCOL), disconnecting: {}",
"Received malformed message code={} data={} (BREACH_OF_PROTOCOL), disconnecting: {}",
ethMessage.getData().getCode(),
ethMessage.getData(),
peer,
e);
Comment on lines +83 to 87
Expand Down
6 changes: 5 additions & 1 deletion ...eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/SnapProtocolManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,11 @@ public void processMessage(final Capability cap, final Message message) {
.map(responseData -> responseData.wrapMessageData(requestIdAndEthMessage.getKey()));
} catch (final RLPException e) {
LOG.debug(
"Received malformed message {} , disconnecting: {}", messageData.getData(), ethPeer, e);
"Received malformed message code={} data={} (BREACH_OF_PROTOCOL), disconnecting: {}",
messageData.getCode(),
messageData.getData(),
ethPeer,
e);
Comment thread
macfarla marked this conversation as resolved.
ethPeer.disconnect(DisconnectReason.BREACH_OF_PROTOCOL_MALFORMED_MESSAGE_RECEIVED);
}
maybeResponseData.ifPresent(
Expand Down
Loading