chore: replace reflect.SliceHeader#261
Merged
garyschulte merged 13 commits intobesu-eth:mainfrom Mar 19, 2025
Merged
Conversation
kevaundray
force-pushed
the
kw/remove-slice-header
branch
2 times, most recently
from
40bca4b to
6f9733d
Compare
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
kevaundray
force-pushed
the
kw/remove-slice-header
branch
from
a504f60 to
ca3f942
Compare
Signed-off-by: kevaundray <kevtheappdev@gmail.com>
garyschulte
reviewed
Mar 19, 2025
garyschulte
reviewed
Mar 19, 2025
Contributor
garyschulte
left a comment
garyschulte
left a comment
There was a problem hiding this comment.
LGTM, possibly a duplicate import and will need merge or rebase after #260
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
garyschulte
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Go 1.17 unsafe.Slice is the recommended way since the go runtime does not make any assumptions about the layout of the slice header