Editorial mdlint and vale updates in HowTo/Configure/ConfigureHA dir#188
Merged
grantnoble merged 31 commits intoMar 1, 2020
Merged
Editorial mdlint and vale updates in HowTo/Configure/ConfigureHA dir#188grantnoble merged 31 commits into
grantnoble merged 31 commits into
Conversation
* Added default data location Signed-off-by: Madeline Murray <madeline.taylor@gmail.com> * Moved licence note Signed-off-by: Madeline Murray <madeline.taylor@gmail.com> Co-authored-by: MadelineAu <40311741+MadelineAu@users.noreply.github.com> Signed-off-by: grantnoble <grant.noble@consensys.net>
Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com> Signed-off-by: grantnoble <grant.noble@consensys.net>
* updating the hdwallet provider package * updating json rpc port in the quickstart docs * pr fixes Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net> Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com> Signed-off-by: grantnoble <grant.noble@consensys.net>
* Added default data location Signed-off-by: Madeline Murray <madeline.taylor@gmail.com> * Fixed typo Signed-off-by: Madeline Murray <madeline.taylor@gmail.com> Co-authored-by: MadelineAu <40311741+MadelineAu@users.noreply.github.com> Signed-off-by: grantnoble <grant.noble@consensys.net>
* Add multi-tenancy information. Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net> * Minor updates. Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net> * Implement reviewer feedback. Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net> * Update diagram. Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net> * Address reviewer feedback. Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net> Co-authored-by: MadelineMurray <43356962+MadelineMurray@users.noreply.github.com> Signed-off-by: grantnoble <grant.noble@consensys.net>
* Remove instructions for broken Azure Quickstart * Rename Quickstart tutorials to Example Tutorials * Rename references to the repository to be sample-networks Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com> Signed-off-by: grantnoble <grant.noble@consensys.net>
* Added default data location Signed-off-by: Madeline Murray <madeline.taylor@gmail.com> * added protocol upgrades content Signed-off-by: Madeline Murray <madeline.taylor@gmail.com> * rework Signed-off-by: Madeline Murray <madeline.taylor@gmail.com> Co-authored-by: MadelineAu <40311741+MadelineAu@users.noreply.github.com> Signed-off-by: grantnoble <grant.noble@consensys.net>
* Added default data location Signed-off-by: Madeline Murray <madeline.taylor@gmail.com> * added protocol upgrades content Signed-off-by: Madeline Murray <madeline.taylor@gmail.com> * rework Signed-off-by: Madeline Murray <madeline.taylor@gmail.com> * Updated link and changed topic name Signed-off-by: Madeline Murray <madeline.taylor@gmail.com> Co-authored-by: MadelineAu <40311741+MadelineAu@users.noreply.github.com> Signed-off-by: grantnoble <grant.noble@consensys.net>
Signed-off-by: wslyvh <wslyvh@users.noreply.github.com> Signed-off-by: grantnoble <grant.noble@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net>
- updated CI config to remove useless DIND -> now directly using the target image with the correct soft installed as it was otherwise not possible to run the jobs locally with Circle CI CLI. - Updated and customised Vale config rules - Updated en customised markdownlint config and rules - moved config files to CI folder - added scripts to run CI jobs locally with Circle CI CLI. Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net> Signed-off-by: grantnoble <grant.noble@consensys.net>
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com> Signed-off-by: grantnoble <grant.noble@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net> Signed-off-by: grantnoble <grant.noble@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net> Signed-off-by: grantnoble <grant.noble@consensys.net>
…ectory (#180) Signed-off-by: Madeline Murray <madeline.taylor@gmail.com> Signed-off-by: grantnoble <grant.noble@consensys.net>
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com> Signed-off-by: grantnoble <grant.noble@consensys.net>
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com> Signed-off-by: grantnoble <grant.noble@consensys.net>
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com> Signed-off-by: grantnoble <grant.noble@consensys.net>
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com> Signed-off-by: grantnoble <grant.noble@consensys.net>
Usual mdlint and vale updates Signed-off-by: grantnoble <grant.noble@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net>
Signed-off-by: grantnoble <grant.noble@consensys.net>
grantnoble
requested review from
MadelineMurray,
NicolasMassart and
bgravenorst
MadelineMurray
approved these changes
Feb 24, 2020
| are sent to multiple nodes, the [`eth_getTransactionCount`](../../../Reference/API-Methods.md#eth_gettransactioncount) | ||
| results can be incorrect. | ||
| Retrieve the nonce for the next transaction using | ||
| [`eth_getTransactionCount`](../../../Reference/API-Methods.md#eth_gettransactioncount). The nonce |
Contributor
There was a problem hiding this comment.
I think the passive voice in this paragraph (ie, how it was written originally) is needed because they are things that might be done by Besu rather than by the user (eg, if you're using EthSigner, eth_getTransactionCount and eth_sendRawTransaction aren't directly called by the user.
Let me know if this doesn't make sense.
Author
There was a problem hiding this comment.
Updated such that Besu obtains the nonce, as follows:
"Besu obtains the nonce for the next transaction using..."
Signed-off-by: grantnoble <grant.noble@consensys.net>
NicolasMassart
approved these changes
Feb 26, 2020
Contributor
NicolasMassart
left a comment
NicolasMassart
left a comment
There was a problem hiding this comment.
Looks good to me. No markdown issues and only usual Vale warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The usual mdlint and vale updates