Adding an update to the docs for the DApp container#127
Merged
NicolasMassart merged 3 commits intoJan 28, 2020
Conversation
Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net>
joshuafernandes
requested review from
EdJoJob,
MadelineMurray and
NicolasMassart
joshuafernandes
commented
Jan 24, 2020
EdJoJob
reviewed
Jan 24, 2020
Contributor
EdJoJob
left a comment
EdJoJob
left a comment
There was a problem hiding this comment.
Flow of information seems good. And much much easier to follow
NicolasMassart
approved these changes
Jan 24, 2020
Contributor
NicolasMassart
left a comment
NicolasMassart
left a comment
There was a problem hiding this comment.
LGTM. Just a few comments but nothing that should prevent the merge.
Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Updates to the quick start documentation around the pet shop truffle example.