Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make package to work correctly with Vite #566

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Aug 7, 2023

Fixes #562
Fixes #469

I'm afraid I missed a couple places this update was required in #356. Perhaps they were added in the two years since I authored the original PR and I didn't catch that there were new ones added. In any case, this seems to work in my testing

@compwright
Copy link

I'd love to see this get merged and released soon!

@benmccann
Copy link
Contributor Author

@bestguy could we get a quick merge of this? I'm afraid my last PR is broken without it. Thanks!

@benmccann
Copy link
Contributor Author

@bestguy @gary-mycase just a quick reminder about this PR. Thanks!

@bestguy
Copy link
Owner

bestguy commented Aug 22, 2023

Thanks, let me confirm this does not break svelte.dev REPL, this was the main issue before with this change.

@pappasam
Copy link

Curious... does this break svelte.dev, or is this lil PR good to go?

@benmccann
Copy link
Contributor Author

benmccann commented Aug 30, 2023

Yes, this will work on the svelte.dev REPL. The last PR (#356) upgraded floating UI where I removed process.env so that it will work in a browser-based environment (floating-ui/floating-ui#2296), so there should no longer be any issue.

@bestguy
Copy link
Owner

bestguy commented Aug 30, 2023

Awesome thanks guys, let me do a sanity check prerelease after work tonight, and if works will release new patch release for this

@bestguy bestguy merged commit a979132 into bestguy:master Aug 30, 2023
@bestguy
Copy link
Owner

bestguy commented Aug 31, 2023

Screenshot 2023-08-30 at 7 12 06 PM

Confirmed worked with Svelte REPL, and released as v5.11.2

Thanks all for the fixes, help, and patience with this! 💟

@jonjes
Copy link

jonjes commented Aug 31, 2023

Sweet! Thanks for this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants