-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make package to work correctly with Vite #566
Conversation
I'd love to see this get merged and released soon! |
@bestguy could we get a quick merge of this? I'm afraid my last PR is broken without it. Thanks! |
@bestguy @gary-mycase just a quick reminder about this PR. Thanks! |
Thanks, let me confirm this does not break svelte.dev REPL, this was the main issue before with this change. |
Curious... does this break svelte.dev, or is this lil PR good to go? |
Yes, this will work on the svelte.dev REPL. The last PR (#356) upgraded floating UI where I removed |
Awesome thanks guys, let me do a sanity check prerelease after work tonight, and if works will release new patch release for this |
Confirmed worked with Svelte REPL, and released as v5.11.2 Thanks all for the fixes, help, and patience with this! 💟 |
Sweet! Thanks for this fix. |
Fixes #562
Fixes #469
I'm afraid I missed a couple places this update was required in #356. Perhaps they were added in the two years since I authored the original PR and I didn't catch that there were new ones added. In any case, this seems to work in my testing