Fix click handling in Modal #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestguy
approved these changes
Feb 15, 2022
|
Thanks, will release patch this week. This may fix #436 as well, but will confirm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using sveltestrap w/ SvelteKit, stopping propagation of the click event in modals breaks SvelteKit's handling of that click event, and so you get a full browser navigation, rather than a navigation within the single-page web app.
To repro this, build a modal with a link in the modal body.
What we actually want here is to stop propagation of the event only if it's a click on the backdrop that we handle.