test: improve alert

[DaniAcu]

Changelog

• Add @babel/plugin-transform-runtime to be able to use async/await
• Add @testing-library/jest-dom/extend-expect to be able to use the expect extentions
• Update alert test to cover all the cases
  • Prevent use classes to get the elements, instead I used the queryByRole.
  • Add dismissible, controllable and without fade cases

[DaniAcu]

@bestguy I noticed that we are using a prop to the toggle event which could be onClose. However I wondering why to use a dispatch as svelte recommend instead to pass a function as parameters 🤔.

I'm a React fan so I like how this looks like but I'm thinking if we could do this more in a svelte way.

[bestguy]

Great, thank you @DaniAcu ! I'll take a look, that makes sense

[DaniAcu]

Let me know if the tests looks good or I need to change something. I could continue contributing with this kind of things 😄

[bestguy]

Thanks, it looks good so far, but I want to be cautious on adding babel changes in case it impacts the published library. It should be fine, but I'll confirm over the weekend. Thank you for the help 👍

[DaniAcu]

@bestguy I noticed that the bundle increase 10KB with the babel plugin. I could configure a specific babel config for testing if that work for you 😄

[bestguy]

Yes that sounds great. Are you sure async was not supported already in tests?

[DaniAcu]

Mmm pretty sure, it was failing because the regeneratorRuntime was not defined which means that the babel pollyfill was not included. So I just add the regenerator plugin that we need to prevent to add all the pollyfills

[bestguy]

Hi @DaniAcu , I think this change to babel.config.js might work without additional plugins:

module.exports = {
  presets: [[
    '@babel/preset-env',
    {
      "targets": {
        "node": "current"
      }
    }
  ], '@babel/preset-typescript']
};

[DaniAcu]

Nice, I will continue adding other config or maybe use NODE_ENV, because we don't want to use node as target for a web component library, it should continue using web as target. Thanks for the suggestion 😊

[bestguy]

Oh yes true, in that case I think can use the babel env test blocks for this, instead of referencing NODE_ENV in code.

[DaniAcu]

@bestguy haha yeah! I pushed that at the same time that you mention haha. I have a problem with package-lock.json. Let me take a look

[DaniAcu]

Now it should be fine 😄

[DaniAcu]

If this is fine, I'll continue cleaning other tests and trying to add new ones to have a better quality in our code.

[bestguy]

Thanks @DaniAcu, I'll sync and try this evening. I might have a suggestion on the babel config but let me confirm first 👍

[DaniAcu]

Any update? 🤔

[bestguy]

Thanks for your patience, one question.

[bestguy]

Great thank you!