Support disabled attr TabPane #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestguy
requested changes
Sep 2, 2021
There was a problem hiding this comment.
Thanks @geoffreymugnier , however I do think this disabled needs to be added to the .d.ts file, correct? TabPane extends <HTMLElementTagNameMap['div']> which does not have disabled afaik.
Oh, that's perfectly right. My bad, I did this one too fast :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just brings support for "disabled" attribute on TabPane. The TS interface hasn't been updated since it is a simple HTML attribute.
The storybook has been updated with an example :