Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add oidc auth #15

Merged
merged 1 commit into from
May 8, 2023
Merged

feat: add oidc auth #15

merged 1 commit into from
May 8, 2023

Conversation

Abirdcfly
Copy link
Member

Fix #3

@Abirdcfly Abirdcfly force-pushed the main branch 3 times, most recently from fde2733 to 52de1de Compare May 6, 2023 03:47
@Abirdcfly Abirdcfly marked this pull request as ready for review May 6, 2023 06:34
@Abirdcfly
Copy link
Member Author

see #3 (comment)

bjwswang
bjwswang approved these changes May 6, 2023
View reviewed changes
Copy link
Member

@bjwswang bjwswang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but remeber to do make veriy before push this pr

bjwswang

This comment was marked as duplicate.

Sign in to view

@Abirdcfly
feat: add oidc auth
ca53cd6 
Signed-off-by: Abirdcfly <[email protected]>
@bjwswang bjwswang merged commit 980afa5 into bestchains:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjwswang bjwswang bjwswang approved these changes

@0xff-dev 0xff-dev 0xff-dev approved these changes

@Lanture1064 Lanture1064 Awaiting requested review from Lanture1064

@nkwangleiGIT nkwangleiGIT Awaiting requested review from nkwangleiGIT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add login command
3 participants
@Abirdcfly @0xff-dev @bjwswang