Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the underlying pageController to the TransformInfo. #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Scopewriter
Copy link

@Scopewriter Scopewriter commented Sep 11, 2019

Hi, I have added the underlying pageController to the TransformInfo, as more fine grained control is sometimes needed in transformers. In my specific use case, I'm also doing animations elsewhere on the screen based on the swipe event and therefore needs the from- and to index, direction etc. in the same event.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 34

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 48.097%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/transformer_page_view.dart 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
lib/transformer_page_view.dart 2 56.52%
Totals Coverage Status
Change from base Build 30: -0.2%
Covered Lines: 139
Relevant Lines: 289

💛 - Coveralls

@shivam-7500
Copy link

Scopewriter can u plz explain how u added a pagecontroller property to the TransformerPageView.builder.
In my specific use case, I also need an explicit controller for controlling the state of the app bar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants