-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh slide dimension settings after each resize #2
base: master
Are you sure you want to change the base?
Conversation
This looks good. Could you squash this into a single commit? |
9b48e0b
to
fb44c7a
Compare
Done |
I don't think it's necessary to set the I recommend moving this whole block into the
|
Changes Unknown when pulling 12f3d8c on medikoo:reread-slide-size into * on bespokejs:master*. |
Changes Unknown when pulling 08a1103 on medikoo:reread-slide-size into * on bespokejs:master*. |
Currently bespoke-scale saves slide dimensions at initialization and refers to it through further process, it doesn't work well, if for some reason we changed slides size during the presentation.
I have such use case when using bespoke-notes plugin. It allows to optionally display notes aside of slide (then slide width becomes twice as long as initial one). Additionally it dispatches
resize
event to invoke any eventual resize related logic. Still bespoke-scale doesn't pick size change, and presentation needs to be brutally reloaded to adjust to new size.Demo of this case: http://medikoo.com/asynchronous-javascript-interfaces/ (press
n
key to toggle notes).This change fixes that.