Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use a single wrapper to apply scale transform to slides #4

Open
mojavelinux opened this issue Aug 12, 2015 · 0 comments

Comments

@mojavelinux
Copy link

When the "transform" option is specified, bespoke-scale wraps an element around each slide individually to apply the scale transform. I don't think this is necessary (and may be impacting performance). I think a single element can be used that wraps all the slides, thus applying the scaling using a single transform.

For example:

<div class="bespoke-scale-parent" style="transform: scale(1.5);">
  <section class="bespoke-slide bespoke-active">
    <h1>Slide 1</h1>
  </section>
  <section class="bespoke-slide bespoke-inactive bespoke-after bespoke-after-1">
    <h1>Slide 2</h1>
  </section>
  ...
</div>

If we want to keep both options of wrapping either the group of slides or each slide individually, I propose that we introduce the option value "transform-group" which will add this new behavior. The existing values will remain unchanged.

mojavelinux added a commit to mojavelinux/bespoke-scale that referenced this issue Aug 12, 2015
… element

- using single wrapper to scale slides if option is transform-group
- fix tests
- add tests for transform-group option
mojavelinux added a commit to mojavelinux/bespoke-scale that referenced this issue Aug 12, 2015
… element

- using single wrapper to scale slides if option is transform-group
- fix tests
- add tests for transform-group option
- document transform-group option in README
@mojavelinux mojavelinux changed the title Add option to use a single wrapper to apply the scale transform to slides Add option to use a single wrapper to apply scale transform to slides Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant