provide an --identifier option to jpackage #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on a similar change to the Badass JLink Plugin: beryx/badass-jlink-plugin@c2190c5 The only difference is the fallback when identifier is not available is jpd.mainClass rather than td.mainClass (which doesn’t exist in the Runtime plugin)
Contributor
Author
|
@siordache Looks like I messed this one up and neither of us caught the mistake (doesn't break anything, but doesn't work correctly either). I'll send another PR soon. UPDATE: PR is ready: #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on a similar change to the Badass JLink Plugin:
beryx/badass-jlink-plugin@c2190c5
The only difference is the fallback when identifier is not available
is jpd.mainClass rather than td.mainClass (which doesn’t exist in the
Runtime plugin)